Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RULES.md: initial document stating the LibreELEC repository usage rules. #4

Closed
wants to merge 4 commits into from
Closed

RULES.md: initial document stating the LibreELEC repository usage rules. #4

wants to merge 4 commits into from

Conversation

lrusak
Copy link
Member

@lrusak lrusak commented Mar 13, 2016

I would like the entire team to comment on this

This is just an initial document, it can be amended in the future to include any other rules that we need to define about the LibreELEC project.

@lrusak
Copy link
Member Author

lrusak commented Mar 14, 2016

Would like to see a few more comments here from the Team, if we think it's ready let me know and I'll squash

MilhouseVH
MilhouseVH reviewed Mar 14, 2016
View reviewed changes
RULES.md

#### LibreELEC Testing Window

Anything listed in the [Major Packages](https://github.com/LibreELEC/LibreELEC.tv/blob/master/RULES.md#major-packages) section **MUST** be submitted as a PR and reviewed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: You don't need https://github.com/LibreELEC/LibreELEC.tv/blob/master/RULES.md on the target, so [Major Packages](#major-packages) should work.

@MilhouseVH
Copy link
Contributor

Other than the nits, it looks good.

My only reservation is this line:

Once an LibreELEC release has entered beta anything in the Major Packages section will NOT be bumped with the exception of Kodi as it progresses to it's final release.

While I agree in general, what if we find a show-stopper bug in say, connman? Ideally we'd patch the package and fix the bug, but in the worst case we may need to bump the package (or even revert a bump). The language here suggests we won't allow ourselves to do either. Maybe we should add a clause to cater for exceptional circumstances, rather than paint ourselves into a corner.

@WeinerRinkler
Copy link

Sorry for offtopic comment, but I do not know where I can ask, your irc channel is invitation only.
I just found this fork and I wonder whats the goals of this fork. Can you answer me this question?
Greetings

@chewitt
Copy link
Member

chewitt commented Mar 20, 2016

@WeinerRinkler - website and forums will be up shortly to explain, thanks :)

@lrusak
Copy link
Member Author

lrusak commented Mar 20, 2016

Updated with @MilhouseVH changes.
Please give a final review.

@lrusak lrusak closed this Mar 29, 2016
@lrusak lrusak deleted the rules branch March 29, 2016 19:25
kodi1 pushed a commit to kodi1/LibreELEC.tv that referenced this pull request Nov 19, 2016
@150balbes
Merge pull request LibreELEC#4 from 150balbes/test
7358dda 
Test
@vpeter4 vpeter4 mentioned this pull request Aug 3, 2017
Merged
@sky42src sky42src mentioned this pull request Jan 11, 2019
Closed
@MilhouseVH MilhouseVH mentioned this pull request Feb 3, 2019
Merged
@eldersixpack13 eldersixpack13 mentioned this pull request Jul 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DOCUMENTATION WORK IN PROGRESS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lrusak @MilhouseVH @WeinerRinkler @chewitt @CvH